Describe your bug or feature request.

This was already done for various Commerce submodules (payment, store, commerce core), let's convert all the remaining ones at once.

Issue fork commerce-3560761

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Issue summary: View changes

tbkot made their first commit to this issue’s fork.

tbkot opened merge request !568

jsacksick’s picture

jsacksick commented
Status: Active » Needs review

  • jsacksick committed 55f44347 on 3.x authored by tbkot 
    feat: #3560761 Convert all remaining hook implementations to OOP hooks...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Done!!
There are 2-3 changes that may be considered "breaking" changes, but we didn't really have a choice. Instantiating the entity storage from the constructor is considered bad practice and was causing circular dependencies.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.