Problem/Motivation

Some changes upstream have created some PHPStan and PHPUnit issues for our project. Fix those.

Steps to reproduce

See a recent CI pipeline.

Issue fork project_browser-3557994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !881

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Fixes for PHPStan (next minor) » Fix PHPUnit and PHPStan failures for the next minor and next major
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Fix PHPUnit and PHPStan failures for the next minor and next major » Fix test failures
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +AI-accelerated

I used Claude to put the #[RunTestsInSeparateProcesses] attribute on the tests which needed it (which is most of them).

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » tim.plunkett
Status: Active » Needs review

The one failing Nightwatch test is beyond my pay grade to figure out, but I think we can deal with it later (follow-up)?

Otherwise this is good to go, everything is passing!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: tim.plunkett » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.