Problem/Motivation

Our browserslist-db is out of date, let's upgrade it and rebuild CSS for all currently supported browser versions.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3555557

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !13634

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Since December 2023, CSS can use the & selector for nesting. This should be fine for all browsers we support:

https://developer.mozilla.org/en-US/docs/Web/CSS/Nesting_selector#browse...

This means the built CSS is easier to read, but has a lot of changes.

Wondering how much PostCSS we are actually using any more given this is in effect...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This has shaved 3344 bytes (about 9%) off the CSS byte count for the navigation performance test.

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented

I was reviewing this and there was another update.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks. Not sure what was going on with the performance tests earlier, but it seems only the StylesheetBytes needs tweaking.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

I confirmed all the edited css files are just generated with this script

git diff origin/11.x --name-only|grep css|while read r;do J=${r/\.css/.pcss.css};if [ ! -f "$J" ]; then echo $J;fi;done

Which printed nothing 👌

Committed to 11.x, backported to 11.3

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • larowlan committed c125a954 on 11.3.x 
    Issue #3555557 by longwave, quietone: Update browserslist-db and rebuild...

  • larowlan committed 2318f0a9 on 11.x 
    Issue #3555557 by longwave, quietone: Update browserslist-db and rebuild...

larowlan closed merge request !13634

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.