Problem/Motivation

We should release 11.3.0 on the latest dependencies.

Steps to reproduce

$ yarn upgrade-interactive

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3552768

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

longwave made their first commit to this issue’s fork.

longwave’s picture

Might have to do this with multiple child issues as there's quite a few different pieces to review.

quietone’s picture

Hoping the remainder can be done here, I have started an MR.

longwave’s picture

Status: Active » Needs review

Thanks for starting this. Upgraded everything else here, this just leaves CSpell to go to v9 and ESLint also to go to v9.

smustgrave’s picture

Status: Needs review » Needs work

Appear to have an issue with stylelint now

longwave’s picture

Let's leave stylelint-config-standard for another issue, as that involves a bunch of manual CSS changes.

longwave’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work

Stylelint issue is resolved but seem to be failing nightwatch now (shocker!)

✖ TypeError                                                                                                         │
│      Cannot read properties of undefined (reading 'get')                                                              │
│       Stack Trace :                                                                                                   │
│       at Object.<anonymous> (/builds/issue/drupal-3552768/core/node_modules/webidl-conversions/lib/index.js:325:94)   │
│       at Module._compile (node:internal/modules/cjs/loader:1364:14)                                                   │
│       at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)                                            │
│       at Module.load (node:internal/modules/cjs/loader:1203:32)                                                       │
│       at Module._load (node:internal/modules/cjs/loader:1019:12)                                                      │
│       at Module.require (node:internal/modules/cjs/loader:1231:19)                                                    │
│       at require (node:internal/modules/helpers:177:18)                                                               │
│       at Object.<anonymous> (/builds/issue/drupal-3552768/core/node_modules/whatwg-url/lib/URL.js:3:21)               │
│       at Module._compile (node:internal/modules/cjs/loader:1364:14)                                                   │
│       at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)  
longwave’s picture

Works for me locally if I run the test alone at least, so not sure what the issue is. Maybe we just roll this back?

$ yarn test:nightwatch modules/ckeditor5/tests/src/Nightwatch/Tests/drupalHtmlBuilderTest.js
[dotenv@17.2.3] injecting env (0) from .env -- tip: 🔑 add access controls to secrets: https://dotenvx.com/ops

[Tests/drupalHtmlBuilderTest]
✔ should return empty string when empty DocumentFragment is passed
✔ should create text from single text node
✔ should return correct HTML from fragment with paragraph
✔ should return correct HTML from fragment with multiple child nodes
✔ should return correct HTML scripts and styles
✔ should return correct HTML from fragment with comment
✔ should return correct HTML from fragment with attributes
✔ should return correct HTML from fragment with self closing tag
✔ attribute values should be escaped
quietone’s picture

CSpell 9.0.0 removed support for Node 18

And cspell tests are failing with

 yarn run spellcheck:core --no-progress --no-must-find-files --cache --cache-strategy content
Unsupported NodeJS version (18.20.8); >=20 is required

But core requires Node 20 for Drupal 11. Why is this testing with Node 18?

quietone’s picture

longwave’s picture

This might be why Nightwatch and friends failed, the new version of JSDom needs Node v20 according to the docs.

andypost made their first commit to this issue’s fork.

andypost’s picture

New image for PHP 8.4 pushed to dev https://git.drupalcode.org/project/drupalci_environments/-/commit/deda6c...

added commit to test it, will push remaining upgrade after testing

andypost’s picture

Status: Needs work » Needs review

fixed perf test and it looks ready to go (needs some time to update all runners with fresh image)

docker run --rm drupalci/php-8.4-ubuntu-apache:production node -v
Unable to find image 'drupalci/php-8.4-ubuntu-apache:production' locally
production: Pulling from drupalci/php-8.4-ubuntu-apache
4b3ffd8ccb52: Pull complete 
e28f179f0a04: Pull complete 
Digest: sha256:3eb2b86a7aed77b52c26958a97371105f603e9cc97a8b5afebfeba4ebc23606a
Status: Downloaded newer image for drupalci/php-8.4-ubuntu-apache:production
v20.19.5
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seemed to do the trick!

  • catch committed 76faa29f on 11.3.x
    Issue #3552768 by quietone, longwave, smustgrave, andypost: Update...

  • catch committed 366553fb on 11.x
    Issue #3552768 by quietone, longwave, smustgrave, andypost: Update...
catch’s picture

Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.