Problem/Motivation

Currently we have a component for site alerts that simply moves Drupal's setup into SDC, which goes against the purpose. It also means we have to do some quirky things like {% set attributes = attributes.removeClass(classes) %} to keep things from bleeding into all the other alerts. This also makes it hard to reuse if we're doing things with editor created notification messages, or any other composition as the setup is _very_ opinionated to Drupal Core.

Submitting a change to create a single Alert component that can be used in varying ways, and mapping system messages to use that instead.

Issue fork prototype-3555280

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jnettik created an issue. See original summary.

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
commented

Starts a WIP. It has some specific logic in it around icons and styles we'll need to generalize more. https://git.drupalcode.org/issue/prototype-3555280/-/commit/d402d41bcc4c...

philip_stier’s picture

philip_stier commented
Version: 5.2.2 » 5.x-dev
Assigned: Unassigned » philip_stier

philip_stier opened merge request !220

philip_stier’s picture

philip_stier commented
Status: Active » Needs review

jldust made their first commit to this issue’s fork.

jldust’s picture

jldust commented
Status: Needs review » Reviewed & tested by the community

jldust’s picture

jldust commented
Assigned: philip_stier » jldust

This has been merged in and will be included in the next tagged release.

jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)