Problem/Motivation

longwave pointed this out in Slack, #coding-standards, saying that we do follow PSR-4.

Steps to reproduce

Proposed resolution

Review and update all text about PSR-4

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork coding_standards-3555131

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented

Actually, I think this should be expanded to review the first paragraph of psr4.md and other instances of 'PSR-4'.

quietone’s picture

quietone commented
Issue summary: View changes

Changing to the standard template because this is cleanup, not a change to the standards.

quietone opened merge request !11

quietone’s picture

quietone commented
Title: Remove "Drupal does not mandate a class-file naming match" » Update references to PSR-4
Issue summary: View changes
Status: Active » Needs review

There are references to SimpleTest as well that need to be removed. Should we do that here or a separate issue?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

These changes already look great, let's do the simpletest one in a followup.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Needs work

I think this still needs a small edit to make sure lines we touch here are correct afterwards.
However, since the typo was there before, you might also argue that it is unrelated, in which case I would also consider this RTBC.
Thanks for opening in any case!

quietone’s picture

quietone commented
Status: Needs work » Needs review

Good point, let's move that to a new issue so we can discuss that point.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc.

  • quietone committed 62d472b3 on main 
    task: #3555131 Update references to PSR-4

By: quietone
By: borisson_
By...
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !11

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.