Problem/Motivation

Remove drupal/redis patch from 5.4.x, same as already done in 6.1.x.

CommentFileSizeAuthor
#8 issue-3554788-redis-patch-no-longer-applies.patch1.05 KBdanrod

Issue fork wxt-3554788

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smulvih2 created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod
danrod’s picture

danrod
Location Ottawa
commented

I added the patch for the 5.4.x branch, please review.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs review
al_trottier’s picture

al_trottier commented

I don't see the changes in the fork.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Ya this is more of a placeholder ticket, it is just the removal of the redis patch from composer.json, same change as parent ticket.

danrod’s picture

danrod
Location Ottawa
commented

Sorry, I forgot to include the patch

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new issue-3554788-redis-patch-no-longer-applies.patch1.05 KB

There you go, this patch should work for the 5.4.x branch, this one removes the patch and upgrades redis to 1.10. Please review.

al_trottier’s picture

al_trottier commented

Thank you. According to @smulvih2, I think we should switch from patch #37 to #49 instead of removing it.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

@al_trottier correct, for 6.1.x we updated drupal/redis to ^1.10 and switched the patch for #49. I think we can do the same thing for 5.4.x, since that version of drupal/redis is good for D10 and D11. This was an important patch so want to make sure we don't drop it from 5.4.x.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Needs work
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs work » Fixed

This has been included in release 5.4.4.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: danrod » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.