Problem/Motivation

Latest drupal/redis 1.10 causes patch to fail. The latest patch that applies to 1.x branch of redis is
#49 in the related ticket, by the same author of our previous patch #37.

Steps to reproduce

Run composer update drupal/redis and see error about patch.

Proposed resolution

Update patch.

CommentFileSizeAuthor
#6 3542143-redis-patch-no.patch1.05 KBdanrod

Issue fork wxt-3542143

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smulvih2 created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod
danrod’s picture

danrod
Location Ottawa
commented

Tested, I'd like a create a patch/MR for this. Basically we need to remove the patch from the composer.json file and change this line

"drupal/redis": "^1.8",

to

"drupal/redis": "^1.10",

Now that there is a new stable release: https://www.drupal.org/project/redis/releases/8.x-1.10

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Ya that's fine, I've already made this change in a feature branch to get the automated tests passing, and created this ticket as a stub to track changes. Will be including this change in the next release, probably over the weekend.

danrod opened merge request !23

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new 3542143-redis-patch-no.patch1.05 KB

For some reason, the MR pipeline run didn't pass because of some unexpected errors

$ [[ $_COMPOSER_YARN_INSTALL == "1" ]] && cd $_WEB_ROOT/core && corepack enable && yarn install
/scripts-190169-6287589/step_script: line 508: cd: web/core: No such file or directory
$ cd $CI_PROJECT_DIR
$ touch $_WEB_ROOT/core/.env
touch: cannot touch 'web/core/.env': No such file or directory

I include the patch file, which I tested and worked ok.

Feel free to use it if needed.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs review
danrod’s picture

danrod
Location Ottawa
commented
Assigned: danrod » Unassigned
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Active

@danrod the redis patch is still needed, just need to switch from patch #37 to #49.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Active » Reviewed & tested by the community

RTBCing this one as this was needed to get automated tests passing again in GitHub, this will be included in next release.

  • smulvih2 committed 55c21e92 on 6.1.x 
    Issue #3542143 by danrod: Redis patch no longer applies
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Reviewed & tested by the community » Fixed

Included in 6.1.2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

al_trottier’s picture

al_trottier commented

Is it possible to include this fix for version 5.4.x?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@al_trottier , couple of ways to fix this while you're waiting.

I'll mention the easiest way first:

composer require drupal/redis:'1.10 as 1.08'

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

@al_trottier yes we can bring this fix into 5.4.x, I created a child issue so we can track this change. For now just add the drupal/redis patch to patches-ignore in your composer.json file.

al_trottier’s picture

al_trottier commented

Perfect, thank you!