Problem/Motivation

When logged into a website that uses CivicTheme, on the Appearance settings page, there is a links that references a CivicTheme github repository. The URLs are 404 error pages.

Steps to reproduce

I haven't yet updated to v1.12.0 to know if this issue still exists, currently I am on V1.11.0

  • when logged into a website, go to /admin/appearance/settings/civictheme
  • In the first black-ish box, it says Your CivicTheme version: 1.11.0
  • The 1.110 is a reference to a link in github https://github.com/civictheme/civictheme/releases/tag/1.11.0
  • The URL is a 404 error page
  • In the second black-ish box, it says Code repository (GitHub)
  • This is a reference to a link in github https://github.com/civictheme/civictheme
  • The URL is a 404 error page

    • Proposed resolution

    Proposed Option 1: remove the link and just have the version number
    Proposed Option 2: update the link (would that be to drupal.org?)

    Remaining tasks

    User interface changes

    API changes

    Data model changes

    Issue fork civictheme-3554779

    Command icon Show commands

    Start within a Git clone of the project using the version control instructions.

    Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    vonnie created an issue. See original summary.

    vonnie’s picture

    vonnie commented
    Title: Incorrect civictheme reference URL on the appearance setting page » Incorrect civictheme reference URL on the appearance settings page
    vonnie’s picture

    vonnie commented
    Issue summary: View changes
    fionamorrison23’s picture

    fionamorrison23 commented

    Looks like the URL is incorrect. v is missing before version number.

    jatin.buzz’s picture

    jatin.buzz commented
    Assigned: Unassigned » jatin.buzz

    Working On It!

    jatin812 opened merge request !22

    jatin.buzz’s picture

    jatin.buzz commented
    Assigned: jatin.buzz » Unassigned
    Status: Active » Needs review

    I checked version 1.12, and the same problem is present there as well.
    I’ve made the necessary changes as suggested by @fionamorrison23 for the links.

    I do have a question — should we link to the UI Kit repository, or would it be better to link to the monorepo-drupal repository (since it’s specific to Drupal)?

    Please review the MR and let me know if any further changes are needed.

    fionamorrison23’s picture

    fionamorrison23 commented
    Assigned: Unassigned » richardgaunt
    fionamorrison23’s picture

    fionamorrison23 commented
    Issue tags: +civictheme-release-1.13
    richardgaunt’s picture

    richardgaunt commented
    Assigned: richardgaunt » danielgry

    Updated URLs pointing issues to Drupal Issue board: https://www.drupal.org/project/issues/civictheme?categories=All and updated homepage: https://civictheme.io

    Thank you for finding the URLs in CT repository.

    richardgaunt’s picture

    richardgaunt commented
    Version: 1.11.0 » 1.x-dev
    Status: Needs review » Reviewed & tested by the community
    richardgaunt’s picture

    richardgaunt commented
    Version: 1.x-dev » 1.13.0
    Assigned: danielgry » Unassigned
    Status: Reviewed & tested by the community » Fixed

    Now that this issue is closed, review the contribution record.

    As a contributor, attribute any organization that helped you, or if you volunteered your own time.

    Maintainers, credit people who helped resolve this issue.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.