Problem / Motivation

The project’s CSS/SCSS files do not fully comply with the coding standards enforced by Stylelint.
Maintaining consistent styling helps improve readability, maintainability, and prevents potential styling issues in the UI.

Proposed Resolution
• Review the current Stylelint configuration.
• Fix or refactor CSS/SCSS code to comply with the defined Stylelint rules.
• Update the Stylelint configuration if necessary to enforce standards consistently.
• Ensure the CI pipeline runs Stylelint and passes without errors.

Acceptance Criteria
• Stylelint reports no violations in the codebase.
• All CSS/SCSS code adheres to the agreed-upon style rules.
• The CI pipeline passes successfully with Stylelint checks.

Issue fork l10n_server-3553023

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

teebeecoder created an issue. See original summary.

teebeecoder’s picture

teebeecoder commented
Assigned: Unassigned » teebeecoder
donquixote’s picture

donquixote commented
Related issues: +#3541994: Fix CI

donquixote opened merge request !87

donquixote opened merge request !88

donquixote changed the visibility of the branch stylelint-not-optional to hidden.

donquixote’s picture

donquixote commented
Status: Active » Needs review
paraderojether’s picture

paraderojether commented
Assigned: teebeecoder » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi

I reviewed MR!88, and confirmed that the Stylelint is now passed on the Gitlab CI.

Moving this to RTBC.
Thank you.

  • donquixote committed 68f88f11 on 3.0.x 
    Issue #3553023: Replace rgba() with rgb() in CSS.

rgba() is an alias of...

  • donquixote committed 0fade480 on 3.0.x 
    Issue #3553023: Fix whitespace in CSS.

(This was originally proposed as...

  • donquixote committed c9b2055a on 3.0.x 
    Issue #3553023: Use double quotes in CSS import.

(This was originally...

  • donquixote committed 7cc821d2 on 3.0.x 
    Issue #3553023: Fix rules order in CSS, to pass stylelint.

(This was...

  • donquixote committed 9c408d08 on 3.0.x 
    Issue #3553023: Fix line breaks in CSS.

(This was originally proposed...

  • donquixote committed 77d16fc5 on 3.0.x 
    Issue #3553023: Make stylelint not optional.

(This was originally...
fmb’s picture

fmb commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.