Problem/Motivation

Various CI jobs are currently failing: PHPCS, PHPStan, Stylelint, CSpell, PHPUnit

Steps to reproduce

Run a pipeline!

Proposed resolution

Fix all the things!

Remaining tasks

User interface changes

-

API changes

-

Data model changes

Issue fork l10n_server-3541994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Starting fixing various things. The code style within the module is not super consistent, so I've tried as best I could to keep up with the respective style of each file, but there are still various changes that could be seen as opinionated. I'm not tied to any of that, though, so if any particular style is preferred or if any changes are considered out of scope, etc., just let me know.

tstoeckler opened merge request !74

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Related issues: +#981870: Skip default argument for view URL does not work and never has so it can be removed
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review

Alright, that was quite a lot more effort than anticipated, in particular I had not expected to become such close friends with MigrateL10nServerGroupTest, but as far as I can tell, that still is the "minimal" amount of changes to get it to pass. Would appreciate some feedback on the changes themselves as well as any process-related suggestions.

teebeecoder made their first commit to this issue’s fork.

donquixote made their first commit to this issue’s fork.

donquixote opened merge request !84

teebeecoder’s picture

teebeecoder commented
Status: Needs review » Closed (won't fix)

Hi @tstoeckler,

Thanks a lot for your merge request and the work you’ve put into it 🙏
After reviewing it, we’ve decided not to approve it for now, as it introduces too many changes in areas we don’t have full control over.

We’d prefer to split this work into several more focused issues:
• PHPCS
• PHPStan
• Stylelint
• CSpell
• PHPUnit

This will help us move forward in a more controlled and progressive way.
Of course, we’ll make sure to give you credit on each issue once it’s merged.

Thanks again for your contribution!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

donquixote’s picture

donquixote commented

@tstoeckler you can comment (or better yet, review) on the other issues, then we can give credit.
I think we it won't be possible otherwise.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Hey there, didn't see the replies due to the issues being closed. No worries regarding the other issues. Glad that things got fixed, that's the most important part 😉

tstoeckler closed merge request !74