Problem/Motivation

There is no real point for us to limit Project Browser blocks by whether the relevant source is enabled or not. In fact, it makes it harder to control the derived Canvas components' visibility, if the blocks themselves may or may not exist.

Proposed resolution

(AI generated) The BlockDeriver class is being updated to derive block plugins for all available source plugins, not just those that are enabled. This change ensures that blocks are exposed for every possible source, regardless of their enabled state, by using all source plugin definitions instead of filtering for enabled ones.

Issue fork project_browser-3552012

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !871

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Reviewed & tested by the community
Issue tags: +Vienna2025, +Drupal CMS

LGTM, checked with Phéna in Vienna sprints

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Needs work

I like what we're doing here, but I don't think we should show a block if it's not enabled. I think handling it by having the block show no output if it's disabled is more The Right Thing™ here.

(Have discussed w/ Adam in the Contrib Room)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Reviewed & tested by the community

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Fixed » Patch (to be ported)

This should probably be backported. I suspect it will be a clean cherry-pick.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Patch (to be ported) » Fixed

This cherry-picked clean to 2.0.x and was pushed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.