Problem/Motivation

Drupal.org packaging system automatically adds the "type": "drupal-module" line to the composer.json, but without it difficult work with the module on localhost.

Proposed resolution

Add "type": "drupal-module" to composer.json.

Remaining tasks

  1. Merge request - branch created by @sweetchuck in #1; merge request !155 created by @sokru in #4
  2. Review and feedback - done by @sokru in #5
  3. RTBC and feedback - done by @mparker17 in #6
  4. Commit - done by @mparker17 in #8
  5. 9.0.x release - released by @mparker17 in 9.0.0-alpha1 by #12
  6. 8.0.x release - released by @mparker17 in 8.0.0-alpha6

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork elasticsearch_connector-3551545

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sweetchuck created an issue. See original summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Active » Postponed (maintainer needs more info)

@sweetchuck, thank you for the contribution!

I recently wrote some documentation on how to set up a local environment for developing elasticsearch_connector-8.x-7.x with ddev/ddev-drupal-contrib... will this help with what you're trying to do? And/or do the instructions there work for you?

(since I've asked a question, I'm moving this to "Postponed (maintainer needs more info)". When you answer, please change it back to "Active" (or some other status if you'd like).

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Postponed (maintainer needs more info) » Needs review

I don't want to use DDEV for contrib development.

I use a method which relies on the "path" composer repository type.

sokru opened merge request !155

sokru’s picture

sokru commented
Status: Needs review » Reviewed & tested by the community

Seems like most of modules have this on their repository, so I'd suggest adding this.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

Agreed; I was having trouble creating the merge request for some reason: thanks @sokru!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Updating the issue summary to document this change for future readers of the release notes.

  • mparker17 committed 3202d2c5 on 8.0.x authored by sokru 
    [#3551545] task: Add type: drupal-module to composer.json

By:...
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

I'll update this issue when the change gets released.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

This change was released in elasticsearch_connector-9.0.0-alpha1 (but doesn't have a release in the 8.0.x release series yet... that's coming soon).

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

(slight change to issue summary)

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

This was released in elasticsearch_connector-8.0.0-alpha6