There is a typo inside ckeditor5.api.php that makes the documentation "harder" to read, especially via the API docs

CommentFileSizeAuthor
#20 3549717-nr-bot_mxbshx1g.txt688 bytesneeds-review-queue-bot
#16 3549717-nr-bot_m6ipgvd1.txt688 bytesneeds-review-queue-bot
#14 3549717-nr-bot_yowkbya_.txt688 bytesneeds-review-queue-bot

Issue fork drupal-3549717

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drcolossos created an issue. See original summary.

drcolossos opened merge request !13373

drcolossos changed the visibility of the branch 11.x to hidden.

drcolossos’s picture

drcolossos commented

Not sure why so many commits came with this merge request...

luismagr made their first commit to this issue’s fork.

luismagr opened merge request !13375

cilefen’s picture

cilefen commented
Version: 11.2.x-dev » 11.x-dev
Status: Active » Needs work

Your commits must be to a branch taken from 11.x. It looks like you used another branch, perhaps 11.2.x, but the merge request is targeted, as required, to the 11.x branch.

luismagr changed the visibility of the branch 3549717-fix-typo to hidden.

luismagr opened merge request !13377

luismagr’s picture

luismagr commented

For whatever reason I had the same issue. I think a made a good MR now. Is it now ok?

Thanks

luismagr’s picture

luismagr commented
Status: Needs work » Needs review

cilefen changed the visibility of the branch 3549717-ckeditor5.api.php-fix-encode to hidden.

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

Yes

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3549717-nr-bot_yowkbya_.txt688 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

cilefen’s picture

cilefen commented
Status: Needs work » Reviewed & tested by the community

I think ^ that was for one of the hidden branches.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3549717-nr-bot_m6ipgvd1.txt688 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

luismagr’s picture

luismagr commented
Status: Needs work » Needs review

It was moved back to Needs work. I've moved again to Needs review.

This is the second time I see an issue like that. I wonder if it's same I saw here https://www.drupal.org/project/drupal/issues/3544005#comment-16273356

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community
drcolossos’s picture

drcolossos commented

Thanks for the heads up on the correct way to merge in #7

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3549717-nr-bot_mxbshx1g.txt688 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +no-needs-review-bot

The bot is correct that this fails the Drupal core commit checks, core/scripts/dev/commit-code-check.sh. It fails the PHPStan checks. But this is a bug that only occurs when there is one file in the diff and the file is an *.api.php file. So, tagging so the bot does not check this anymore.

quietone closed merge request !13375

quietone closed merge request !13373

  • quietone committed 2b00a20b on 11.x 
    Issue #3549717 by drcolossos, luismagr, cilefen: ckeditor5.api.php fix @...

  • quietone committed 2aacc39d on 11.2.x 
    Issue #3549717 by drcolossos, luismagr, cilefen: ckeditor5.api.php fix @...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

For reference the documentation for working with Drupal's Gitlab is in the guide, Using GitLab to contribute to Drupal.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

quietone closed merge request !13377

luismagr’s picture

luismagr commented

Thanks for the documentation and info @quietone I didn't know that tag no-needs-review-bot. I'll take a look to the gitlab documentation as well.

Thanks all for the help

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.