Problem/Motivation

PHP 8.4 has been released, and this module is triggering a "use explicit nullable type" deprecation.

PHP Deprecated:  Drupal\single_content_sync\Utility\CommandHelper::getEntitiesToExport(): Implicitly marking parameter $entity_ids_to_export as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/single_content_sync/src/Utility/CommandHelper.php on line 133

Deprecated: Drupal\single_content_sync\Utility\CommandHelper::getEntitiesToExport(): Implicitly marking parameter $entity_ids_to_export as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/single_content_sync/src/Utility/CommandHelper.php on line 133
PHP Deprecated:  Drupal\single_content_sync\Utility\CommandHelperInterface::getEntitiesToExport(): Implicitly marking parameter $entity_ids_to_export as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/single_content_sync/src/Utility/CommandHelperInterface.php on line 45

Deprecated: Drupal\single_content_sync\Utility\CommandHelperInterface::getEntitiesToExport(): Implicitly marking parameter $entity_ids_to_export as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/single_content_sync/src/Utility/CommandHelperInterface.php on line 45
CommentFileSizeAuthor
#3 implicit-nullable-deprecation-3548592-3.patch3.59 KBjavier_rey
#2 implicit-nullable-deprecation-3548592-2.patch1.47 KBjavier_rey

Issue fork single_content_sync-3548592

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

javier_rey created an issue. See original summary.

javier_rey’s picture

javier_rey commented
StatusFileSize
new implicit-nullable-deprecation-3548592-2.patch1.47 KB
javier_rey’s picture

javier_rey commented
StatusFileSize
new implicit-nullable-deprecation-3548592-3.patch3.59 KB

There were more warnings in the code, added a new patch to fix them.

jastraat made their first commit to this issue’s fork.

jastraat opened merge request !181

jastraat’s picture

jastraat commented
Status: Active » Needs review
glynster’s picture

glynster commented

Confirmed and works well for us. +1 RTBC

jkriigel’s picture

jkriigel commented

Patch confirmed. +1 RTBC

baikho’s picture

baikho commented
Status: Needs review » Reviewed & tested by the community
nicolas bouteille’s picture

nicolas bouteille commented

+1 RTBC thx!

mahaprasad’s picture

mahaprasad commented

+1 RTBC, Thank you!

nginex made their first commit to this issue’s fork.

  • nginex committed 2ea6ac3a on 1.4.x authored by jastraat 
    Issue #3548592: Add nullable indicator to functions.
nginex’s picture

nginex commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

phubear’s picture

phubear commented
Version: 1.4.x-dev » 1.4.16

This issue also exists for version 1.4.16, but separate patch will need to be applied.

phubear’s picture

phubear commented
Version: 1.4.16 » 1.4.x-dev

Never, the patch issue was resolved.