Problem/Motivation

PHP Codesniffer 4.0 has been released.

Proposed resolution

Update the dependency to 4.0, and make sure everything still runs.

Remaining tasks

Fix up https://github.com/pfrenssen/coder/pull/272

API changes

Issue fork coder-3548073

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !28

ptmkenny’s picture

ptmkenny commented
Title: php_codesniffer 4.0 has been released » Update php_codesniffer to 4.0

johnatas made their first commit to this issue’s fork.

johnatas’s picture

johnatas commented

Hello,

I’ve just made a commit implementing the deprecated/breaking changes mentioned here:

Everything seems to be working on my side, however I’m encountering the bug #3217297 again, and I’m not sure where it’s coming from :(

johnatas’s picture

johnatas commented
Status: Active » Needs work
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Hey thanks!

I think we should probably make a new Coder 9.x branch when we adopt this major upgrade.

Feel free to continue working in a pull request again 8.3.x in the meantime. We do pull requests on Github, please open one against https://github.com/pfrenssen/coder

klausi closed merge request !28

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Parent issue: » #3552621: Release new Coder 9 major upgrade
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

I committed the work you started to 9.x, continuing at https://github.com/pfrenssen/coder/pull/272

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue tags: +Vienna2025

Tagging.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 8.3.x-dev » 9.x-dev

  • klausi authored 2433a7be on 9.x 
    refactor(phpcs): Upgrade to 4.x in composer and adapt all sniffs (#...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Fixed

Merged.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.