Problem/Motivation

Alterations to SCSS variables (that are not related to colour) in the files `variables.base.scss` or `variables.components.scss` within a subtheme, do not work since CivicTheme 1.11, without requiring the subtheme to override each component that uses those variables.

Steps to reproduce

1. Create a new subtheme, no new components.
2. Update the `$ct-border-radius` to `100%` in the subtheme's `components/variables.base.scss`
3. Compile, clear cache and review components in Drupal - the border radius will be using the civictheme's initial value, and not the new custom value.

Proposed resolution

Implement CSS variables to allow base theme components to use subtheme variable changes.

Comments

alan.cole created an issue. See original summary.

fionamorrison23’s picture

Assigned: Unassigned » richardgaunt
Status: Active » Needs review
Issue tags: +civictheme-release-1.12
richardgaunt’s picture

Assigned: richardgaunt » danielgry
richardgaunt’s picture

Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

fionamorrison23’s picture

Version: 1.11.0 » 1.12.0
fionamorrison23’s picture

Assigned: danielgry » Unassigned
fionamorrison23’s picture

Assigned: Unassigned » danielgry
Status: Fixed » Needs review
danielgry’s picture

Assigned: danielgry » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.