Problem/Motivation

Work is currently happening within Commerce Shipping to support editing/adding shipments in the context of the order view page (See #3550156: Implement shipping information edit modal).

The logic is implemented in a new formatter added to the shipments field.

Commerce core should only be responsible for outputting the shipments field if present.

Issue fork commerce-3545883

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rinasek created an issue. See original summary.

khiminrm made their first commit to this issue’s fork.

tbkot made their first commit to this issue’s fork.

tbkot opened merge request !531

jsacksick made their first commit to this issue’s fork.

jsacksick’s picture

jsacksick commented
Status: Active » Needs work

@tbkot: I think we should find a way for Commerce to support both.
If the order.shipments field is present, we use that, otherwise we check if order.shipping_information is present.

This way we shouldn't need to force a minimum requirement on Commerce shipping 3.0. Plus it is kind of annoying as we have a circular dependency. (We need the latest Commerce, and Commerce conflicts with prior versions of Shipping).

This isn't ideal.

jsacksick’s picture

jsacksick commented
Title: Impement shipping information edit modal » Support rendering shipments from the order view page
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Related issues: +#3550156: Implement shipping information edit modal

Retitling, for clarity as this task isn't actually about implementing the modal itself since all the logic lives in Commerce Shipping.

  • jsacksick committed a61039a3 on 3.x authored by tbkot 
    [#3545883] feat: Support rendering shipments from the order view page...
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.