Problem/Motivation

Three issues:

1. #3386783: Missing config schema for views plugins added the schema definitions for views.area.facets_summary_area and views.filter.facets_summary_filter in facets_exposed_filters module while the plugins are defined in facets_summary and can be used without facets_exposed_filters. So these need to be moved in facets_summary.

2. Also views.filter.facets_filter should be in facets_exposed_filters where the plugin is defined but is currently in facets.

3. Also facets.views.schema.yml should be fixed #3535191: SchemaIncompleteException when saving Views with Facets filters - Missing processor schema definitions

4. After #3481448: Config schema fix several processor schemas are not defined/missing:
- hide_active_items_processor
- hide_1_result_facet #3544120: Missing config schema for hide_1_result_facet processor
- list_item
- show_only_deepest_level_items_processor
- translate_entity_aggregated_fields
- uid_to_username_callback

Steps to reproduce

1.
- Enable facets_summary but not facets_exposed_filters
- Setup a view with both facets_summary_area & facets_summary_filter
- Save with schema_checker enabled in services.yml or run config:inspector to see the error reported.

2. N/A

3. These can be reproduced by using those processors in a facet and save with with schema_checker or running config:inspector.

Proposed resolution

1. & 2. Move things accordingly.
3. Add missing processor definitions.

Remaining tasks

?

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#7 3544226-7.diff1.84 KBherved
#3 3544226-3.diff656 bytesherved

Issue fork facets-3544226

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

herved created an issue. See original summary.

herved opened merge request !324

herved’s picture

herved commented
Title: Several schema definitions in wrong sub-modules » Misplaced schema definitions (wrong submodule)
Issue summary: View changes
StatusFileSize
new 3544226-3.diff656 bytes
herved’s picture

herved commented
Status: Active » Needs review
herved’s picture

herved commented

There is another issue, several processor schemas are not defined/missing after #3481448: Config schema fix:
- hide_active_items_processor
- hide_1_result_facet
- list_item
- show_only_deepest_level_items_processor
- translate_entity_aggregated_fields
- uid_to_username_callback

Should we extend the scope here?

herved’s picture

herved commented
Title: Misplaced schema definitions (wrong submodule) » Schema definitions issues
Issue summary: View changes
Status: Needs review » Needs work
herved’s picture

herved commented
Issue summary: View changes
Status: Needs work » Needs review
Related issues: +#3544120: Missing config schema for hide_1_result_facet processor
StatusFileSize
new 3544226-7.diff1.84 KB
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The demo module requires views_ajax_history but it's not listed in composer.json so the tests fail.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

It then failed because views_filters_summary was required.

There are still some actual test failures:

Drupal\Tests\facets\Unit\FacetSource\FacetSourcePluginManagerTest:

    Facet Source Plugin Manager (Drupal\Tests\facets\Unit\FacetSource\FacetSourcePluginManager)
     ⚠ Construct
     ✔ Get definitions
     ✘ Invalid definitions with only·id
       ┐
       ├ Error: Unknown named parameter $id
    
       ┴
     ✘ Invalid definitions with only·display_id
       ┐
       ├ Error: Unknown named parameter $display_id
    
       ┴
     ✘ Invalid definitions with only·label
       ┐
       ├ Error: Unknown named parameter $label
    
       ┴
     ✘ Invalid definitions with no·label
       ┐
       ├ Error: Unknown named parameter $id

Drupal\Tests\facets\Kernel\FacetManager\DefaultFacetManagerTest:

    Default Facet Manager (Drupal\Tests\facets\Kernel\FacetManager\DefaultFacetManager)
     ⚠ Get enabled facets
     ⚠ Get facets by facet source id
     ⚠ Alter query cacheability metadata
     ✘ Build cacheability metadata with 0
       ┐
       ├ Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema
       │
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
       │ /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215
       ┴
     ✘ Build cacheability metadata with 1
       ┐
       ├ Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema
       │
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
       │ /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215
       ┴
     ✘ Build cacheability metadata with 2
       ┐
       ├ Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema
       │
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206
       │ /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487
       │ /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
       │ /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215
       ┴
herved’s picture

herved commented

I didn't dig much further tbh because if I'm not mistaken the report is the same as 3.0.x https://git.drupalcode.org/project/facets/-/pipelines/582244
So this is probably out of scope here and deserves its own issue?
Thanks for looking into it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The issues in DefaultFacetManagerTest appear to be more missing schema, this time in the facets_processors_collection test module, so is relevant for this issue; I don't know about the other one, I haven't dug into it yet.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

strykaizer made their first commit to this issue’s fork.

  • strykaizer committed 4fd21457 on 3.0.x authored by herved 
    [#3544226] fix: Schema definitions issues

By: herved
By: damienmckenna...

strykaizer opened merge request !337

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Issue tags: +Vienna2025

  • strykaizer committed a6830021 on 3.0.x 
    [#3544226] fix: Schema definitions issues

By: herved
By: damienmckenna...
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.