Problem/Motivation

If you have a form element that is coded as #unique: false, it's treated as though it's #unique: true.

Steps to reproduce

I wasn't able to get the admin UI to create a #unique: false setting on an element, but it can be done on the Source page. In my case, I think I ended up with some of these as a result of migrating forms with Webform Migrate.

Proposed resolution

The #unique key is currently being checked with isset(). It should be checked with empty() instead.

Remaining tasks

Merge request posted for review.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork webform-3543591

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zengenuity created an issue. See original summary.

zengenuity opened merge request !718

zengenuity’s picture

zengenuity commented
Issue summary: View changes
Status: Active » Needs review

jrockowitz made their first commit to this issue’s fork.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.