Problem/Motivation
Our blockers to update to Drupal 11 are solved. Let's provide Drupal 11 compatibility.
Proposed resolution
Fix all the issues detected by the Upgrade Status module.
Remaining tasks
- ☑ Support for the default_argument_skip_url setting is removed in views.view.group_recurring_events_series.yml on line 890
- ☑ Support for the default_argument_skip_url setting is removed in views.view.recurring_events_registrations.yml on line 1257
- ☐ Tests are passing on Drupal 11
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | recurring-events--d11-minimum-compatibility.patch | 4.72 KB | chrisla |
Issue fork recurring_events-3541881
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
plopesc@pfrenssen Are those items flagged against last 3.0.x version?
We're already using the module in D11 and it seems the mentioned lines do not contain the problematic code indicated in the IS.
Comment #3
pfrenssenComment #4
pfrenssenI did a fresh check against the latest dev version and there is only one task left.
Comment #7
pfrenssenCrediting @chris dart who did this work in #3480491: Roadmap to modernize code for D11 + PHP 8.3.
Comment #8
pfrenssen@plopesc you're right, I still had this task on my to-do list, but in the meantime most of the issues are already solved!
I will also make sure the tests pass on Drupal 11.
Comment #9
pfrenssenAll green on Drupal 10 and Drupal 11!!
Comment #10
plopescGreat job!
It seems that the MR has conflicts now, though.
Comment #12
pfrenssenFixed the conflict and a new coding standards error that popped up.
Comment #14
chrisla commentedI just needed a minimum working version for Drupal 11 and I can't wait for the 3.0 branch to be released. The MR from this issue could not be applied directly to current 2.0 codebase.
I have taken code from this issue and created a minimum-requirements patch that gets recurring_events 2.0 working on a D11 site. I'm not doing a merge request so as not to clutter up the code. This also requires the Drupal 11 compatibility code from https://www.drupal.org/project/field_inheritance/issues/3480537
Step 1:
- add mglaman/composer-drupal-lenient
Step 2:
- Add patches to cweagans/composer-patches in composer.json
-- https://git.drupalcode.org/project/field_inheritance/-/commit/f9f854a943...
-- https://www.drupal.org/files/issues/2026-01-12/recurring-events--d11-min... (from this issue)
Step 3:
- update or require field_inheritance and recurring_events modules
Comment #15
plopescThank you for your interest in the module @chrisla.
I'm looking forward for a stable release as well and your feedback is highly appreciated.
We have been working in D11 for months in our platform with the following versions:
"drupal/recurring_events": "3.0.x-dev#6ce9cc25a798460ff1f63eee164b7335c4742924",and"drupal/field_inheritance": "3.x-dev#4f34b584d33cf7c3348ab853a7a6e58319aac86e",.Would you mind to confirm whether this setup works for you and we will try to iterate from there?
Thank you in advance!
Comment #16
chrisla commentedYep, I've been following the progress on 3.0 and hope to have time in the next 2 months to contribute as I will be rolling out a new project. However, that project and another one need to be D11 and so I was needing to have a D11-ready version ASAP. For me, in about a week of use, the patched version I'm using has worked perfectly with recurring_events 2.0
Comment #17
plopescThank you for your interest. I will try to work on at least an 3.x alpha version in the near future.