Problem/Motivation

PHPStan is failing in the 3.0.x dev branch:

 ------ -----------------------------------------------------------------------
  Line   recurring_events.views.inc
 ------ -----------------------------------------------------------------------
  16     Attribute class Drupal\Core\Hook\Attribute\LegacyHook does not exist.
 ------ -----------------------------------------------------------------------

 ------ -----------------------------------------------------------------
  Line   src/Hook/RecurringEventsTokensHooks.php
 ------ -----------------------------------------------------------------
  26     Attribute class Drupal\Core\Hook\Attribute\Hook does not exist.
  92     Attribute class Drupal\Core\Hook\Attribute\Hook does not exist.
 ------ -----------------------------------------------------------------

 ------ -----------------------------------------------------------------
  Line   src/Hook/RecurringEventsViewsHooks.php
 ------ -----------------------------------------------------------------
  20     Attribute class Drupal\Core\Hook\Attribute\Hook does not exist.
 ------ -----------------------------------------------------------------

These failures were introduced in a commit that was made directly in the branch without first running tests: https://git.drupalcode.org/project/recurring_events/-/commit/3af491ed176...

Issue fork recurring_events-3541875

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pfrenssen created an issue. See original summary.

plopesc made their first commit to this issue’s fork.

plopesc opened merge request !166

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Thank you for the heads up!

Tests are green again.

Those changes were necessary to make 3.0.x fully compatible with D11. We had some hook conflicts between recurring_events and recurring_events_views modules when views hooks were declared in the recurring_events.views.inc file.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Fixed

Looks great! I will merge this. Probably we can close #3510919: Drupal 11: Views Data Alter hook clash now. I will have a look there.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.