Problem/Motivation

Unable to add the module in D11

Solution

Need to update info.yaml to add D11 support

Issue fork tealiumiq-3541777

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cbuvaneswaran created an issue. See original summary.

cbuvaneswaran opened merge request !22

cbuvaneswaran’s picture

cbuvaneswaran commented
Status: Active » Patch (to be ported)
cbuvaneswaran’s picture

cbuvaneswaran commented

Hi Team,

I created the issue fork and added the D11 support in info.yml. Please validate and merge the PR and then the release the D11 supported version of the module.

PR details: https://git.drupalcode.org/project/tealiumiq/-/merge_requests/22

Thanks and Regards,
Buvaneswaran

jastraat’s picture

jastraat commented

Getting the following error with Drupal 11 on /admin/config/services/tealiumiq/defaults:
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/tealiumiq/src/Form/Defaults.php on line 33 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

This means that the module cannot easily support both Drupal 11 and versions prior to 10.2:
https://www.drupal.org/node/3404140

jastraat’s picture

jastraat commented

Also the sub-module for tealiumiq needs the info file updated as well.

jastraat’s picture

jastraat commented
Version: 8.x-1.5 » 8.x-1.x-dev
Assigned: cbuvaneswaran » jastraat
Status: Patch (to be ported) » Needs review

Updated the MR to add more Drupal 11 compatibility. Given that Drupal 11 ConfigFormBase is not compatible with versions prior to 10.2 I reflected that in the info files.

Note that the current method for requiring the necessary dependent modules for the sub-module does not work but that pre-dates the need for Drupal 11 compatibility and could be handled in a separate issue.

schiavone’s picture

schiavone commented
Status: Needs review » Fixed

This looks good. Merged. Thanks.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

schiavone’s picture

schiavone commented
Status: Fixed » Needs work

Looks like we need to revisit this. In the contruct method the $typedConfigManager cannot be protected. See https://www.drupal.org/node/3404140

public function __construct(
    ConfigFactoryInterface $configFactory,
    protected TypedConfigManagerInterface $typedConfigManager,
    Tealiumiq $tealiumiq,
  )

schiavone’s picture

schiavone commented
Status: Needs work » Fixed

Resolved and in the 2.0 release.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.