Problem/Motivation

Nightly pipelines are failing now that CORE_STABLE > 11.2

Steps to reproduce

See https://git.drupalcode.org/project/dashboard/-/pipelines/572528

Failed asserting that the text of the element identified by '//*[@id="block-primary-local-tasks"]/ul/li[2]/a' equals 'Edit layout'.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Edit layout'
+'Preview'

Proposed resolution

Remaining tasks

Fix.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork dashboard-3541274

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito opened merge request !66

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes

Changed proposed resolution.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » plopesc
Status: Active » Needs review

This fixes the build + new test.
I'm leaving a test that only runs for 11.1.x, locally it passes, but we will discontinue soon support for 11.1.x (and it's actually not running in any gitlab ci job)

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

Thank you for keeping the module up to date.

  • penyaskito committed b93a4fd8 on 2.x 
    Issue #3541274 by penyaskito, plopesc: Fix build dependent on core major...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.