APCu requirement for 32MB always displays since APCu 5.1.25

Related to #3539331-27: Skip failing test with incorrect warning for system requirements about APCu memory

The related issue already commited but it's not enough so probably the issue is complimentary to #3539331: Skip failing test with incorrect warning for system requirements about APCu memory

Indeed, the other issue started as a critical due to repeated test fails on HEAD. We committed a stop-gap to skip that part of the test. There’s now an MR there to fix the status report, too, that needs review. But probably best for scope management and history to move that MR here and close that one as the hot-fix-the-tests issue it started as.

I’ll work on moving over the code and cleaning up the other issue, stay tuned.

Opened MR here, with the code from https://git.drupalcode.org/issue/drupal-3539331/-/tree/3539331-fallback-...

Since both myself and @godotislate worked on that MR, adding credit for them, too.

Tagging to be smashed.

Also, crediting @driskell for the clear bug report with correct analysis of the bug and accurate proposed resolution. Had @godotislate and I seen this issue while we were scrambling to fix #3539331: Skip failing test with incorrect warning for system requirements about APCu memory it would have saved some time, since we had to debug why the status report thought 3GB < 32MB and only with a little debugging output did we discover apc.shm_segments was 0 and then search to find it had been removed upstream. 😅

Pipeline here is mostly green, except for the dreaded package_manager build test fails. 😬 Queued that one to re-run. But this should be ready for review (and hopefully RTBC) now.

Thanks,
-Derek

Change looks good to me, monitoring project got hit by this as well but worse (division by zero error). Not related to this issue directly, just similar code.

Hi all!

Just wondering if this issue will be back-ported to D 10.5+ since Im experiencing the same problem.

Thanks in advance for the hard work!

Committed 6078270 and pushed to 11.x. Thanks!

We need an MR for 11.2.x - things have moved around a lot because hook stuff. ONce we have this in 11.2.x then yes we should get this in 10.6.x and 10.5.x too...

Great, thanks! I'll work on a backport MR right now. Stay tuned.

Yeah, this didn't apply at all. Had to re-implement it in system.install (different indentation, etc, etc).

https://git.drupalcode.org/project/drupal/-/merge_requests/12988 for 11.2.x and lower.

https://git.drupalcode.org/issue/drupal-3538854/-/pipelines/572272 is basically looking good. I assume we ignore the PHP 8.5 phpunit deprecation warnings for these backport MRs, right?

Back to NR. Probably worth another set of eyes to look at this before the backport is RTBC.

thank you!

EDIT 8.5 is supposed to fail, fixes in #3523596: [meta] PHP 8.5 support

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Committed da29801 and pushed to 11.2.x. Thanks!
Committed and pushed 265731eb2b7 to 10.6.x and 392338a899e to 10.5.x. Thanks!

I did a cherry pick back to 10.x and fixed up the tiny conflict on commit.

Thanks! Doesn't look like you actually pushed the commit to 11.2.x. This issue doesn't show it, nor do I see it in Git.

Sweet, thanks!