I really like this module! It's awesome how it can set up a menu as the disclosure or menubar ARIA pattern without the user having to write javascript. However, I've noticed it's incompatible with the contributed Menu Block module. It would be great to be able to use these together.
Line 338 of accessible_menu.module only tests for a base plugin id strictly equal to 'system_menu_block'.
Menu Block hides system menu blocks and replaces them with a base plugin id of 'menu_block'.
It seems like all that's needed to make Accessible Menu compatible with Menu Block is a small addition to the if statement on line 338 of accessible_menu.module, but I'm not 100% sure.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
nickdjmHey @kwiseman, thanks for the MR!
I'm not familiar with that module, however from a quick look through it's source code I think you're correct in thinking this is the only change needed.
I'd like to confirm that's the case before merging this in, but it looks promising!
Are you able to confirm everything works as expected with this change?
Comment #4
kwiseman commentedYes it works. I tried it (that exact change) on a development version of a real website and Accessible Menu's javascript is still able to set up the roles and keyboard interactivity.
Comment #5
kwiseman commentedComment #6
nickdjmAwesome, merged.
Thanks!
Comment #7
nickdjm