Problem/Motivation

I would like to add a HTML title attribute to the link provided by field group link.

This can improve accessibility.

Steps to reproduce

Proposed resolution

Add a configuration option for title attribute (text with token replacement).

Remaining tasks

Field group module has an option to provide attributes of any kind. Maybe this would even be a better solution, but seems a bit more difficult to implement so I am going with only title attribute for the moment.

User interface changes

API changes

Data model changes

Issue fork field_group_link-3537876

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

stefan.korn created an issue. See original summary.

stefan.korn opened merge request !6

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
Issue summary: View changes
stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
Assigned: stefan.korn » Unassigned
Status: Active » Needs review
rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Needs work

Hi
The code looks good except for the mix usage of [] and array. Can you use the short version in the new code? I wouldn't mind if you also convert some arrays around the code changed like $defaults.
Thanks for the contribution!

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
Status: Needs work » Needs review

Okay, I (hopefully) replaced all old array syntax to new one in this file.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.