The button on the cards does not look right in dark mode in Gin. (Also need to check the modal popup button)
Install latest Drupal and Gin, enable the Gin theme and set it as your admin theme. Go to Gin settings and enable Dark Mode. Visit Project Browser pages and note the button color.
Apply CSS to make the button look correct in BOTH light mode and dark mode with Gin.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | lightmode.png | 74.34 KB | libbna |
| #7 | after(dark).png | 72.36 KB | libbna |
| #7 | before (dark).png | 80.14 KB | libbna |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
anirudhsingh19 commentedworking on it.
Comment #4
anirudhsingh19 commentedImproved the colors of the select button. When using the gin admin theme for both in light and dark mode.
Comment #5
anirudhsingh19 commented@phenaproxima Thanks for the feedback. I'll look into it and try to accomplish it using classes. But, in the gin.css file there is already a huge amount of styling done using CSS IDs (#project-browser), I'm not sure why it has been used.
Comment #6
anirudhsingh19 commentedUsed CSS classes instead of IDs, also resolved the stylelint errors which were leading to pipeline failure. Moving to Needs review.
Comment #7
libbna commentedI have reviewed MR !833. Earlier, the buttons appeared white, but after applying the changes from this MR, it now displays correctly in dark mode. I also checked in light mode, and the buttons look good there as well.
Comment #8
phenaproximaScreenshots look good to me, no objections to the CSS (although I'm not really the one to make the determination about that).
Comment #11
chrisfromredfinTested and works great. Thanks everyone! Merged to 2.1.x and cherry-picked clean to 2.0.x