Problem/Motivation
After testing my D11 instance on PHP 8.4, I've come across a few issues:
Deprecated: Drupal\page_manager\Entity\PageVariantViewBuilder::resetCache(): Implicitly marking parameter $entities as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/page_manager/src/Entity/PageVariantViewBuilder.php on line 46
Deprecated: Drupal\page_manager_ui\Form\VariantPluginAddBlockForm::buildForm(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/page_manager/page_manager_ui/src/Form/VariantPluginAddBlockForm.php on line 65
Deprecated: Drupal\page_manager\Plugin\SectionStorage\PageManagerSectionStorage::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/page_manager/src/Plugin/SectionStorage/PageManagerSectionStorage.php on line 206
PHP Deprecated: Drupal\entityqueue\Controller\EntityQueueUIController::subqueueListForEntity(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/entityqueue/src/Controller/EntityQueueUIController.php on line 76
Steps to reproduce
If you have the module installed, by running drush you'll get the errors
Proposed resolution
Explicitelly declare the variable as nullable: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullabl...
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comments
Comment #3
danrodComment #4
danrodI've create a MR for it, kindly review.
For some reason the tests are failing, but I see that the other MRs are having the same problem so I guess that's fine for now.
Comment #5
danrodComment #6
danrodComment #7
dhruv.mittal commentedreviewing it
Comment #8
dhruv.mittal commentedChanges looks good to me so moving it to RTBC
Comment #11
rajab natshahHaving the other way with adding
?Comment #12
xem8vfdh commentedRelease would be nice :)
Comment #13
jaydarnellMR 46 appears to fix the issue.
Comment #14
josephcheekAdded PHP 8.4 tag so it will show up in the list of PHP 8.4 fixes at https://www.drupal.org/project/issues/search?issue_tags=PHP%208.4
Also +1 to RTBC. Would love to see a merge.
Comment #15
smulvih2+1 RTBC. Adding patch file here to use with my project.
Comment #16
mably commented+1 RTBC
Comment #17
danrod+1 RTBC, works fine in the 8.x-4.x-dev version
Comment #19
joelpittetThank you all for reporting this and sorry for the delay. I will cut a release shortly.
Comment #22
xem8vfdh commenteda stable release? Its been quite some time since even a pre-release. A stable sure would be nice :)
Comment #23
joelpittetPlanning to but need to find a few moments to fix the failing tests due to core drift. If anyone wants to create the follow up for that, that would help me a bit.
I have the fixes half done this morning.