Problem/Motivation

Contact is being deprecated, see the parent issue for details. This issue is for removing Contact from the standard profile.

For an example see how this was done for the RDF module in #3243121: Remove RDF module from the Standard profile.

Steps to reproduce

Proposed resolution

Remove Contact module from the Standard profile.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

TBA

CommentFileSizeAuthor
#16 3535775-nr-bot_klugyhiq.txt91 bytesneeds-review-queue-bot
#13 3535775-nr-bot_oimz_4db.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3535775

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !12712

quietone’s picture

quietone commented
Status: Active » Needs work
hhvardan’s picture

hhvardan commented
Assigned: Unassigned » hhvardan
hhvardan’s picture

hhvardan commented
Assigned: hhvardan » Unassigned
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Did a small review but instead of deleting some of the tests that were using contact we probably need to find a replacement so we aren't losing functionality coverage for other things that happened to be using contact

hhvardan’s picture

hhvardan commented
Assigned: Unassigned » hhvardan
smustgrave’s picture

smustgrave commented

Actually majority is out of scope too, should be about just removing from standard profile not fixing all tests

hhvardan’s picture

hhvardan commented
Assigned: hhvardan » Unassigned
Status: Needs work » Needs review

I rolled back the previous commits that included migration tests and other changes that were out of scope. The current implementation now focuses specifically on removing Contact from the Standard profile.

smustgrave’s picture

smustgrave commented

Still appears to be touching migration tests

hhvardan’s picture

hhvardan commented

Moved Contact to missing paths in review tests and enabled Contact module in upgrade tests.

smustgrave’s picture

smustgrave commented

I’ll have to take a look later not sure why all the migrations need to be updated if we are just removing a module from a profile.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3535775-nr-bot_oimz_4db.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

hhvardan’s picture

hhvardan commented
Assigned: Unassigned » hhvardan
hhvardan’s picture

hhvardan commented
Assigned: hhvardan » Unassigned
Status: Needs work » Needs review

Merged latest 11.x core and resolved conflicts. Restored the feedback_contact_form recipe.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3535775-nr-bot_klugyhiq.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Vienna2025

zviryatko made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Looks ready now

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +11.3.0 release priority
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I find it ready

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks good, glad we were able to maintain the test coverage more or less straightforwardly.

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • catch committed ccaa289f on 11.x 
    Issue #3535775 by quietone, hhvardan, smustgrave, andypost, zviryatko:...

catch closed merge request !12712

andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed change record https://www.drupal.org/node/3553411 looking for help to improve

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.