Needs work
Project:
Drupal core
Version:
main
Component:
filter.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Jul 2025 at 09:01 UTC
Updated:
18 Nov 2026 at 00:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
graber commentedComment #4
graber commentedComment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
mortona2k commentedRebased and simplified. Added deprecation warning and draft change record for requiring FilterManager and RendererInterface arguments, but they are optional for now.
The
$filter_managerargument is changed to$filterManager, so there is a warning in the CR that code using named parameters to instantiate the class will need to be updated. However there is no good reason to have written it that way, and I found no code that uses it via Drupal Code Query MCP.Used AI to rebase.
Comment #9
mortona2k commentedComment #10
mortona2k commentedSimilar CRs:
Constructor property promotion across Drupal core
Says there should be no BC break for the vast majority of code, but code constructing a class with named arguments may need updating where a parameter changed from snake_case to camelCase.
New parameters added as optional with a deprecation (CR) in #3226806, then made required for D12 in #3620747.
Same for #3539178 and #3064751. #3223012 used the same pattern and still has its fallback on main.
image_path_flush(), image_style_options() and IMAGE_DERIVATIVE_TOKEN have been deprecated
#3567618 added a required ImageDerivativeUtilities argument to ImageFormatter, ImageUrlFormatter and MediaThumbnailFormatter with no deprecation; the CR does not mention the constructor change.
If this is targeting D12, should I just make the arguments required with no deprecation warnings?