Add an option to 'hide filter guidelines' on text fields

Blocked on parent

The parent issue has been committed.

nice idea! in D7 there was better_formats for that IIRC

Thanks for reminding me of the great Better Formats module @andypost. I see that it just got a new maintainer who wants to focus on getting it ready for Drupal 10.

https://www.drupal.org/project/allowed_formats has had this feature for years, that's why I suggested to add it to core. We've only made that project half-obsolete now.

I thought I would have this problem, having just switched from allowed_formats to the new core feature. But for some reason filter tips are not showing for me on the form, just the discreet "About text formats" link.

I'm not so sure how they are hidden now that allowed_formats is uninstalled. I thought it might be Gin's feature to hide help text, replaced with a (?) toggle. There is just an empty div.

<div class="js-filter-guidelines js-form-wrapper form-wrapper filter-guidelines" data-drupal-selector="edit-field-summary-0-format-guidelines" id="edit-field-summary-0-format-guidelines" data-once="filter-guidelines">
</div>

+1000 to this

+1001 to this, but as @sime says filter tips are not showing on the form, just "About text formats" link.
We are also using Gin

As a workaround you can hide it with this CSS snippet:

/* Hide text format help text */
.page-content .filter-wrapper {
  display: none;
}

Created MR to add the Hide Help and Hide Guidelines widget settings to core in a similar way as they are in Allowed Formats module.
Also added basic test coverage.

It will require some extra work, but let's use this initial approach to gather feedback and get the ball rolling.

Thank you for your review @smustgrave!

I was waiting for approach validation before going farther.

Fixed the broken tests.

Regarding the form, the idea is to define the settings at widget level, like in allowed_formats module, not at field level. But this can be discussed if the field level approach is preferred.

Regarding the form, the idea is to define the settings at widget level, like in allowed_formats module, not at field level. But this can be discussed if the field level approach is preferred.

+1 for adding it on widget level, so its easier to make allowed_format contrib module obsolete.

As well as providing options on each entity form display it might be nice to have a global option that sets this once everywhere. The widget configuration should probably then have options to either use the site-wide default setting, or explicitly hide/show the help and guidelines.

@mstrelan was quicker :-) exactly what I wanted to add.

+1 for a parent global and child sub setting overriding the global setting. Users are used to this from other admin UI experience. We have it in URL alias pattern, in states like "published" (default and on each node) and many other corners.

MR seems good.

+1 for having a global setting, overrideable on widget level.

If we wanted a global switch should this be a permission (or pair of permissions) provided by filter.module?

Also, I've said this in other issues - checking a box to hide something feels the wrong way round, the checkbox should be checked if we are showing something.

+1 to "Display tooltips" per longwave's suggestion - my preference would be off by default.

+1 here as well for off by default. i almost always end up hiding these.

yep, +1 for hiding the long tips, would be nice to have a tooltip when hovering a (?)

+1 to off by default as @longwave suggested

Shall we postpone this on #3505370: Remove 'filter tips' page and deprecate the long format API?

#3505370: Remove 'filter tips' page and deprecate the long format API is in, so moving back to NW.

The link 'About text formats' was removed from the TextFormat render element in #3505370: Remove 'filter tips' page and deprecate the long format API. Is there anything left to do here?

Yep this is obsoleted by #3505370: Remove 'filter tips' page and deprecate the long format API which hides it permanently for everyone.

There is still the filter guidelines when the Text Format does not use an editor: