Problem/Motivation

Upstream issue reported

https://github.com/entreprise7pro/bootstrap/issues/5

Merged upstream PR and cut a new release v3.4.7

Need to test the integration into 8.x-3.x and review

Original reported issue:
#3528472: Uncaught TypeError: can't convert Object to string Plugin https://cdn.jsdelivr.net/npm/entreprise7pro-bootstrap@3.4.5/dist/js/bootstrap.js:796 jQuery 2

Steps to reproduce

See upstream issue

Proposed resolution

See 8.x-3.x dev branch, run the dev build to test it

Remaining tasks

Review and test

User interface changes

API changes

Data model changes

Comments

joseph.olstad created an issue. See original summary.

  • joseph.olstad committed 46c79c25 on 8.x-3.x 
    Issue #3533858 by joseph.olstad: Review/upgrade to entreprise7pro/...

joseph.olstad credited meltonml.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

adding credits

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
herved’s picture

herved commented

- Installed latest core 11.x
- Enabled dependencies (jquery_ui, jquery_ui_draggable, jquery_ui_resizable) + bootstrap theme 3.x-dev
- Tested the navbar hamburger on mobile and collapse, all ok
- I can see both fixes from entreprise7pro/bootstrap are present
https://github.com/entreprise7pro/bootstrap/commit/00ee4669f6e24c3635a2b...
https://github.com/entreprise7pro/bootstrap/commit/51adf3b32846a78f3b8e7...
- +1 LGTM

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Needs review » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/bootstrap/releases/8.x-3.36

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.