Simply expands on their documentation and makes it more understandable, with more examples.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community
Dries’s picture

Status: Reviewed & tested by the community » Fixed

I've committed this to CVS HEAD. Thanks Dmitri.

The patch failed to apply against DRUPAL-6 so I'm marking this 'fixed' for now. If this needs to be backported, feel free to re-open this issue.

ksenzee’s picture

Status: Fixed » Active
  * When viewing a page at the path "admin/build/types", for example, arg(0)
- * would return "admin", arg(1) would return "content", and arg(2) would return
- * "types".
+ * returns "admin", arg(1) returns "content", and arg(2) returns "types".

This isn't this patch's fault, but reading it I noticed that there's a mismatch here. If the path is now "admin/build/types", arg(1) returns "build", not "content". I'm not on my dev machine or I'd provide an actual patch -- sorry about that.

jhodgdon’s picture

Issue tags: +Novice

RE #3 - The arg() doc header has been changed again, due to more changes in core paths, and now says

When viewing a page at the path "admin/structure/types", for example, arg(0) returns "admin", arg(1) returns "content", and arg(2) returns "types".

http://api.drupal.org/api/function/arg/7

This does need to be fixed. Good project for a novice doc contributor.

jastraat’s picture

Assigned: dmitrig01 » jastraat

sorry - I didn't think this had been assigned and I was looking for a good practice issue.

jastraat’s picture

FileSize
835 bytes
jastraat’s picture

Status: Active » Reviewed & tested by the community
jhodgdon’s picture

jastraat: You cannot normally mark your own patch as "reviewed and tested by the community". You need to wait for someone else to review it.

I've just reviewed it. It's fine. :)

jhodgdon’s picture

Assigned: jastraat » Unassigned
jastraat’s picture

Generally no - but it was a very, very tiny string change :)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.