Problem/Motivation

As a result of work done in #3448498: Public method Redirect::generateHash() should unify path before generating the hash, the path is converted to lowercase when generating the hash. That should be unnecessary.

public static function generateHash($source_path, array $source_query, $language) {
  // Remove leading and trailing slashes, and convert to lowercase.
  $source_path = trim(mb_strtolower($source_path), '/');
  $hash = [
    'source' => mb_strtolower($source_path),

Proposed resolution

Remove duplicate use of mb_strtolower

Issue fork redirect-3525915

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

krystalcode created an issue. See original summary.

krystalcode’s picture

Status: Active » Needs review
StatusFileSize
new699 bytes

alexpott made their first commit to this issue’s fork.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

Nice find @krystalcode - I converted your patch into a MR to make things easier for the maintainers.

berdir made their first commit to this issue’s fork.

  • berdir committed 4df4c3a4 on 8.x-1.x authored by alexpott
    Issue #3525915 by alexpott, krystalcode: Duplicate function call when...
berdir’s picture

Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.