Problem/Motivation

When using webform 6.3.x with devel_generate, generateSubmissions() lacks a : void return type

Steps to reproduce

  1. Enable webform and devel_generate.
  2. Generate some test submissions

Proposed resolution

Change signature to protected function generateSubmissions(array $values): void

CommentFileSizeAuthor
#3 webform-6.3.0-beta2-3524877.patch921 bytesyovince

Issue fork webform-3524877

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yovince created an issue. See original summary.

yovince opened merge request !631

yovince’s picture

yovince
Location Melbourne
commented
StatusFileSize
new webform-6.3.0-beta2-3524877.patch921 bytes

Also upload a patch compatible with 6.3.0-beta2.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs work

Thanks for the patch.

Why is this change required? Please update the issue summary.

Tests are not passing.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Reviewed & tested by the community

This MR is an API cleanup, which I think is okay.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Add : `void` return type to WebformSubmissionDevelGenerate::generateSubmissions() » Remove return value from WebformSubmissionDevelGenerate::generateSubmissions()

I see it is a protected method and its return value is not used. In theory someone could sub-class this and use the return value. This could have a change record. I have updated the issue title to make it more clear what is happening, so perhaps the release notes are sufficient, rather than using a change record.

  • jrockowitz committed 50a8b10d on 6.3.x authored by yovince 
    Issue #3524877 by yovince, liam morland: Remove return value from...
jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

  • jrockowitz committed 50a8b10d on 6.x authored by yovince 
    Issue #3524877 by yovince, liam morland: Remove return value from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.