Problem/Motivation

New failures since PHPStan upgrade upstream

Steps to reproduce

Proposed resolution

Issue fork project_browser-3523168

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett opened merge request !801

fjgarlin’s picture

fjgarlin commented

PHPStan is now happen. PHPCS is not, one variable became unused after the change.

fjgarlin’s picture

fjgarlin commented
Status: Active » Reviewed & tested by the community

The code looks good and phpstan is green again. The failing tests are not introduced here.
RTBC.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

It gets bad when you start to glaze over when seeing the red. Green is best!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.