Problem/Motivation

Alerts should display on pages they are configured for.
All behat tests are failing on the SDC branch.
The XHR request is not being made.

--- Failed steps:

001 Scenario: Alerts can be viewed on homepage                          # tests/behat/features/content_type.civictheme_alert.view.feature:19
      And I should see the text "[TEST] Test alert title Homepage only" # tests/behat/features/content_type.civictheme_alert.view.feature:24
        The text "[TEST] Test alert title Homepage only" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

002 Scenario: Alerts should follow the visibility settings         # tests/behat/features/content_type.civictheme_alert.view.feature:32
      And I should see the text "[TEST] Test alert body all pages" # tests/behat/features/content_type.civictheme_alert.view.feature:38
        The text "[TEST] Test alert body all pages" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

003 Scenario: Alerts should be dismissed and not shown in the same session # tests/behat/features/content_type.civictheme_alert.view.feature:42
      And I should see the text "[TEST] Test alert body all pages"         # tests/behat/features/content_type.civictheme_alert.view.feature:48
        The text "[TEST] Test alert body all pages" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

004 Scenario: Alerts should be dismissed and not shown in same session for logged in user # tests/behat/features/content_type.civictheme_alert.view.feature:70
      Then I should see the text "[TEST] Test dismissing alert body all pages"            # tests/behat/features/content_type.civictheme_alert.view.feature:75
        The text "[TEST] Test dismissing alert body all pages" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

005 Scenario: Alerts should be dismissed and shown if their content was updated # tests/behat/features/content_type.civictheme_alert.view.feature:91
      Then I should see the text "[TEST] Test dismissing alert body all pages"  # tests/behat/features/content_type.civictheme_alert.view.feature:96
        The text "[TEST] Test dismissing alert body all pages" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

006 Scenario: Alerts should not be shown if the date range is not today # tests/behat/features/content_type.civictheme_alert.view.feature:116
      Then I should see the text "[TEST] Test alert body all pages"     # tests/behat/features/content_type.civictheme_alert.view.feature:121
        The text "[TEST] Test alert body all pages" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

007 Scenario: Alerts visibility                                      # tests/behat/features/content_type.civictheme_alert.view.feature:125
      Then I should see the text "[TEST] Test alert body visibility" # tests/behat/features/content_type.civictheme_alert.view.feature:143
        The text "[TEST] Test alert body visibility" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

Work to be done

1. Investigate how the alert JS is being added to CivicTheme pages and why it is not being executed correctly.

Work done

https://github.com/civictheme/monorepo-drupal/pull/1375

Added component libraries to page so we can call the JS to generate the styled alerts.

Comments

richardgaunt created an issue. See original summary.

richardgaunt’s picture

Issue summary: View changes

richardgaunt’s picture

Issue summary: View changes
richardgaunt’s picture

Status: Active » Needs review
fionamorrison23’s picture

Assigned: Unassigned » danielgry
Issue tags: +civictheme-release-1.12
richardgaunt’s picture

Fixed in the last release

richardgaunt’s picture

Status: Needs review » Fixed
Issue tags: -civictheme-release-1.12 +civictheme-release-1.11

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

danielgry’s picture

Assigned: danielgry » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.