Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
database system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 May 2025 at 22:17 UTC
Updated:
3 Jul 2025 at 15:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
mondrakeComment #5
mondrakeChanges made
Comment #6
longwaveLooks good to me, tagging for change record updates as it does make sense to merge this with the other one - let's do that on commit.
Comment #7
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
longwaveThe bot is wrong.
Comment #9
longwaveActually no, something has changed in PHPStan, I get the same locally, though the PHPStan CI job passes?
Comment #10
mondrakeLooks like bot and your local have an old baseline version? I added the return type and the core CI job tells me to remove the above from the baseline
Comment #11
mondrakehttps://git.drupalcode.org/issue/drupal-3522513/-/pipelines/490932
Comment #12
smustgrave commentedSeems phpstan is still failing.
Comment #13
mondrakeComment #14
smustgrave commentedTests seem to be happy now
@longwave you tagged for change record updates?
Comment #17
catchUpdated the previous CR to include this issue.
This isn't disruptive so can still be removed in 12.x, updated the deprecation version to 11.3
Committed/pushed to 11.x, thanks!
Comment #18
catch