Deprecate passing $root to \Drupal\Core\Database\Connection::createConnectionOptionsFromUrl

The CI pipeline is failing with a PHPStan error.
Do we need a deprecation message test?

We must follow this documentation to deprecate anything in Drupal.

https://www.drupal.org/about/core/policies/core-change-policies/how-to-deprecate

Hello @charlliequadros

I tried to update the deprication message by following the instructions
Please review and suggest if any other changes are required

Also, the change record needs to be created.

Hi @adwivedi008 ,

I left a comment, but I'm just starting to contribute to the community.
Maybe we can check with someone more experienced to see if what I said makes sense.

Hi @mondrake,

I have updated the code according to the deprecation guidelines for method parameters in Drupal:

The $root parameter is marked as deprecated, but the method itself remains functional.
A @trigger_error() has been added following the documentation.
The @see annotation references the correct change record.
However, I noticed that some tests fail due to deprecation warnings related to passing $root. These warnings appear in multiple functional JavaScript tests, such as:

ToolbarActiveTrailTest
RegistrationWithUserFieldsTest
ClickSortingAJAXTest
FilterTest
FieldDialogsTest
ViewsWizardTest

Would you recommend updating these tests to avoid passing $root, or should we add an explicit handling for this in the code? Let me know the best approach so I can make the necessary adjustments.

Thank you!

Left comments on MR.

All code changes look good.
The deprecation message testing has been added.
For me it is RTBC.

This is kinda ugly, but I don't see a better way. We can deprecate the same argument from Database::convertDbUrlToConnectionInfo() in a followup, because similarly it is no longer used now.

Committed 4e42a4f and pushed to 11.x. Thanks!

Also published the change record and updated it a little with instructions on what to actually do.

Followup: #3522513: Deprecate passing $root to \Drupal\Core\Database\Database::convertDbUrlToConnectionInfo()