Problem/Motivation

Visiting events/*/revisions and events/*/revisions/* urls, the admin theme is not used. Because the `_admin_route` is not set.

Steps to reproduce

  • In Appearance > Administration theme, set an admin theme.
  • Setup recurring_events, add some eventinstance.
  • Visit events/*/revisions and events/*/revisions/*
  • Admin theme not used.

Proposed resolution

Set `_admin_route` to TRUE in EventInstanceHtmlRouteProvider.

Remaining tasks

N/A

User interface changes

Admin theme will be used on events/*/revisions and events/*/revisions/* routes.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#4 recurring_events-3522413-4.patch4.32 KBckng
#3 recurring_events-3522413-3.patch2.18 KBckng

Issue fork recurring_events-3522413

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ckng created an issue. See original summary.

ckng opened merge request !147

ckng’s picture

ckng
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new recurring_events-3522413-3.patch2.18 KB
ckng’s picture

ckng
Primary language English
commented
StatusFileSize
new recurring_events-3522413-4.patch4.32 KB

plopesc made their first commit to this issue’s fork.

  • plopesc committed 84b9d70f on 2.0.x authored by ckng 
    Issue #3522413: Revisions routes not using admin theme

  • plopesc committed 17c3a4fe on 3.0.x authored by ckng 
    Issue #3522413: Revisions routes not using admin theme
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Nice suggestion. It works great.

Merged into 2.0.x and cherry-picked into 3.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.