Closed (outdated)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 May 2025 at 02:37 UTC
Updated:
18 Nov 2025 at 15:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nicxvan commentedChanges are stacking up, I'm restricting this to two modules
Comment #4
nicxvan commentedStill got some work to do on block, but this is getting close I think.
Comment #7
nicxvan commentedOk I need to actually write the CR.
I'm not sure how I feel about making it protected, it is technically api now, not sure why we want to restrict this further.
I also am not sure about the deprecation message either.
Comment #8
berdir> I'm not sure how I feel about making it protected, it is technically api now, not sure why we want to restrict this further.
I think we similar discussions before.
Not every function is automatically an API, reducing API surface isn't a bad thing (for things that aren't useful). Making it protected/internal means it's easier to change and refactor it in the future.
There are no known calls (just one reference for someone doing something similar, it's just a way to share the code between the two hooks. It's exactly like what is done in #3502014: Clean up hook implementations in the Taxonomy module.
Comment #9
berdircoding standards failed.
Comment #10
nicxvan commentedComment #11
berdirAbout the CR and things being removed without replacement, search for "There is no replacement". tons of deprecations like that, for example node_mark(), which has this CR: https://www.drupal.org/node/3514189
Personally, I'd not even bother with a CR and see if someone would prefer to have one. For me, with change records, it's always a question of value vs noise. There's not much useful that we could write except that you'd need to copy paste the code, which seems obvious, and the fact that there are no known usages on that. On the other side is the noise: dozens to hundreds of people will see some kind of notification, like a tweet, toot or whatever. But that's my personal opinion and the documentation page about that is still a bit vague.
Comment #12
borisson_I think this issue could use a title update, from the title it is not very clear what happened, I tried to change it so it's clearer.
Comment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
nicxvan commented