Problem/Motivation

Preprocess and template preprocess recently were able to be converted.
Some hooks were missed too.

Steps to reproduce

Proposed resolution

Convert what is missing, if the MR is small consider DI and organization.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3522361-nr-bot.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3522361

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

Title: Finish conversion of bigpipe, block, and block_content » Finish conversion of bigpipe and block

Changes are stacking up, I'm restricting this to two modules

nicxvan’s picture

Still got some work to do on block, but this is getting close I think.

nicxvan changed the visibility of the branch 3522361-finish-conversion-of to hidden.

nicxvan’s picture

Ok I need to actually write the CR.

I'm not sure how I feel about making it protected, it is technically api now, not sure why we want to restrict this further.

I also am not sure about the deprecation message either.

berdir’s picture

> I'm not sure how I feel about making it protected, it is technically api now, not sure why we want to restrict this further.

I think we similar discussions before.

Not every function is automatically an API, reducing API surface isn't a bad thing (for things that aren't useful). Making it protected/internal means it's easier to change and refactor it in the future.

There are no known calls (just one reference for someone doing something similar, it's just a way to share the code between the two hooks. It's exactly like what is done in #3502014: Clean up hook implementations in the Taxonomy module.

berdir’s picture

Status: Active » Needs work

coding standards failed.

nicxvan’s picture

Status: Needs work » Needs review
berdir’s picture

About the CR and things being removed without replacement, search for "There is no replacement". tons of deprecations like that, for example node_mark(), which has this CR: https://www.drupal.org/node/3514189

Personally, I'd not even bother with a CR and see if someone would prefer to have one. For me, with change records, it's always a question of value vs noise. There's not much useful that we could write except that you'd need to copy paste the code, which seems obvious, and the fact that there are no known usages on that. On the other side is the noise: dozens to hundreds of people will see some kind of notification, like a tweet, toot or whatever. But that's my personal opinion and the documentation page about that is still a bit vague.

borisson_’s picture

Title: Finish conversion of bigpipe and block » Finish hook attribute conversion of bigpipe and block modules

I think this issue could use a title update, from the title it is not very clear what happened, I tried to change it so it's clearer.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

nicxvan’s picture

Status: Needs work » Closed (outdated)