Good:
hook_civictheme_layout_suppress_page_regions_alter() references the content type "civictheme_page", which is created by the theme

Less good:
hook_civictheme_automated_list_view_info_alter() references a content type with machine name "event", which is not quite the machine name of the "Event" content type created by the theme.

Proposed change:
Have hook_civictheme_automated_list_view_info_alter() reference content type "civictheme_event" to help those of us blindly copying and pasting

Comments

jdleonard created an issue. See original summary.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Assigned: jdleonard » Unassigned
Status: Active » Needs review

PR: https://github.com/civictheme/monorepo-drupal/pull/1366

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Version: 1.10.0 » 1.x-dev
richardgaunt’s picture

richardgaunt commented
richardgaunt’s picture

richardgaunt commented
Status: Needs review » Reviewed & tested by the community

fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.12
fionamorrison23’s picture

fionamorrison23 commented
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » richardgaunt
Status: Reviewed & tested by the community » Needs review
richardgaunt’s picture

richardgaunt commented
Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.x-dev » 1.12.0
Assigned: richardgaunt » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.