Problem/Motivation

A number of issues with the pager template:

  • Use of single quotes on HTML attributes
  • Awkward use of setting/manipulating attributes
  • Hiding of the ellipsis element, rather than providing suitable help text.

Issue fork prototype-3518002

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jnettik created an issue. See original summary.

jnettik opened merge request !195

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
commented
Status: Active » Needs review

Marking as ready for review.

jldust’s picture

jldust commented
Assigned: jnettik » jldust
Status: Needs review » Reviewed & tested by the community

This looks good, I know there are a few additional edits that got addressed for the component in issue 3528722 so I'll likely need to merge that first and then resolve conflicts.

pixelwhip made their first commit to this issue’s fork.

pixelwhip’s picture

pixelwhip commented
Status: Reviewed & tested by the community » Fixed

I've rebased this on top of the latest from 5.x and fixed the conflicts mentioned by jldust. This has been merged into 5.x.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)