Problem/Motivation

Trying to make seamless wysiwig editing work under drupal and this module is one of the closest. It's pretty good but has a few issues, this is one.

Steps to reproduce

Enter edit mode by clicking the " Edit Mode" button
Click on editable content
Edit the content but don't click outside of the editing frame
Click the save icon in the top bar

Changes are not saved

Proposed resolution

Save should initiate save to tempstate before it saves globally

Remaining tasks

User interface changes

Save should initiate save to tempstate before it saves globally

API changes

Data model changes

Issue fork edit_plus-3517910

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pfolk created an issue. See original summary.

tim bozeman’s picture

tim bozeman commented

Oooo ya good point. We will definitely do that

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !7

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
pfolk’s picture

pfolk commented

This fixes the problem as far as I can tell!

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs review » Reviewed & tested by the community

I checked it from my side it is working as expected according to the issue requirement. As there is not any pipeline failure and test cases issue with MR so moving it to RTBC.

tim bozeman’s picture

tim bozeman commented
Related issues: +#3520370: Save does not take effect until you click outside of the edit box

Thank you very much!

I gave fixing this a try over on the navigation+ side by making the save button wait until the tempstore is done updating. Is that working for y'all?

tim bozeman’s picture

tim bozeman commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.