[1.0.x] Node Token Filter

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us; it does not contain enough PHP code to really assess your skills as a developer.

Do you have any other project hosted on drupal.org that we could instead review? It needs to have most of the commits (but preferably all the commits) done by you, in at least a branch.

We need a project were most of the commits, but preferable all the commits, have been done by you. We do not review patches or merge requests.

I am closing this application because the status set by the applicant was Active, and the applicant has not posted any comment in this application in the past two weeks.

Feel free to re-open it, if you are the applicant and you are sure you can follow this application the time necessary to get it closed as fixed.

Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.

What I reported in my previous comment still holds true. Taking out boilerplate code, this is the only PHP code to review.

  public function settingsForm(array $form, FormStateInterface $form_state) {
    $form['replace_empty_token'] = [
      '#type' => 'checkbox',
      '#title' => $this->t('Replace empty tokens'),
      '#description' => $this->t('Remove tokens from text if they cannot be replaced with a value'),
      '#default_value' => $this->settings['replace_empty_token'],
    ];

    return $form;
  }

  public function process($text, $langcode) {
    $node = $this->routeMatch->getParameter('node');
    if (!empty($node)) {
      $token_data = ['node' => $node];
    }
    else {
      if ($this->moduleHandler->moduleExists('group')) {
        $group = $this->routeMatch->getParameter('group');
        if (!empty($group)) {
          $token_data = ['group' => $group];
        }
      }
    }

    if (!empty($token_data)) {
      $token_options = ['clear' => $this->settings['replace_empty_token']];
      $text = $this->token->replace($text, $token_data, $token_options);
    }
    return new FilterProcessResult($text);
  }

1. FILE: README.md

The README file is missing the required sections - Project introduction and Configuration.

2. FILE: src/Plugin/Filter/NodeFilterToken.php

  /**
   * VideoEmbedWysiwyg constructor.
   *
   * @param array $configuration
   *   Plugin configuration.
   * @param string $plugin_id
   *   Plugin ID.
   * @param mixed $plugin_definition
   *   Plugin definition.
   * @param \Drupal\Core\Routing\RouteMatchInterface $route_match
   *   The route match.
   * @param \Drupal\Core\Routing\RouteMatchInterface $module_handler
   *   The module handler.
   * @param \Drupal\Core\Utility\Token $token
   *   The token service.
   */
  public function __construct(array $configuration, $plugin_id, $plugin_definition, RouteMatchInterface $route_match, ModuleHandlerInterface $module_handler, Token $token) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.

That is a commit for a issue fork.
If you do not have the permission to make commits for that project, and you made most of the commits (preferably, all the commits) for that project, that project cannot be used for these applications.

I am changing priority as per Issue priorities.

@aram.gevorgyan Either this project contains more code (which is not boilerplate code), or you use a different project where you made most of the commits.

This thread has been idle, in the Needs work state with no activity for about six months or more; the application has been created about 11 months ago or more. Therefore, I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.