Problem/Motivation

We would like to standardize the structure and formats around our components with JavaScript

Remaining tasks

- Breakout functions
- Include docblocks for each new function
- Drupal specific elements will occur inside the attached behaviour
- Should leverage only vanilla JS
- Review naming conventions, specifically event handling
- Should leverage `let` or `const` instead of `var`

Issue fork prototype-3517817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

philip_stier made their first commit to this issue’s fork.

philip_stier opened merge request !203

philip_stier’s picture

philip_stier commented
Status: Active » Needs review
pixelwhip’s picture

pixelwhip commented

Merge request looks good to me!

jldust’s picture

jldust commented
Assigned: Unassigned » jldust
Status: Needs review » Reviewed & tested by the community

I was able to test the updated accordion and it worked great, this has been merged in and will be included in the next tagged release.

  • jldust committed 319b7c3c on 5.x authored by philip_stier 
    feat: #3517817 Components: Standardize JS - Tabs Content

By: jldust
By...
jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed

This has been included in the most recent release

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)