Problem/Motivation

We would like to standardize the structure and formats around our components with JavaScript

Remaining tasks

- Breakout functions
- Include docblocks for each new function
- Drupal specific elements will occur inside the attached behaviour
- Should leverage only vanilla JS
- Review naming conventions, specifically event handling
- Should leverage `let` or `const` instead of `var`

Issue fork prototype-3517816

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

jldust opened merge request !213

jldust’s picture

jldust commented
Status: Active » Needs review

I've updated the JS structure for the slideshow component and introduced testing for this component.

jldust’s picture

jldust commented
Assigned: Unassigned » jldust
Status: Needs review » Needs work

This needs to wait till the other build tools issue has been resolved so we can pull that work

jldust’s picture

jldust commented
Status: Needs work » Needs review

The updated build tools have been pulled in

jldust’s picture

jldust commented
Status: Needs review » Needs work

Ah need to fix build for this component still

jldust opened merge request !224

jldust changed the visibility of the branch 3517816-components-standardize-js to hidden.

grgcrlsn321 made their first commit to this issue’s fork.

  • jldust committed 8768da12 on 5.x 
    feat: #3517816 Components: Standardize JS - Slideshow

By: jldust
By:...
jldust’s picture

jldust commented
Status: Needs work » Reviewed & tested by the community

This has been merged in and will be included in the next tagged release.

jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)