Problem/Motivation

We would like to standardize the structure and formats around our components with JavaScript

Remaining tasks

- Breakout functions
- Include docblocks for each new function
- Drupal specific elements will occur inside the attached behaviour
- Should leverage only vanilla JS
- Review naming conventions, specifically event handling
- Should leverage `let` or `const` instead of `var`

Issue fork prototype-3517814

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

b-ry made their first commit to this issue’s fork.

b-ry opened merge request !208

jldust’s picture

jldust commented
Status: Active » Needs work

Overall this works well, only thing that needs some adjustments is closing the search bar with the escape key. It seems to require pressing the key twice before closes.

jldust’s picture

jldust commented
Status: Needs work » Reviewed & tested by the community

  • jldust committed 3954fe56 on 5.x authored by b-ry 
    feat: #3517814 Components: Standardize JS - Search Bar

By: jldust
By: b...
jldust’s picture

jldust commented

This has been merged in and will be included in the next tagged release.

jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed

This has been included in the most recent release

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)