Problem/Motivation

We are using the Drupal Symfony Mailer in combination with Workflow Notifications (and the reroute_email_symfony_mailer IS enabled). Our workflow notification emails appear to use the 'BCC' field instead of the 'To' field, which generates an error from reroute_email complaining that
"TypeError: Drupal\reroute_email\Plugin\RerouteEmailHandler\HookMailAlter::setHeader(): Argument #2 ($value) must be of type string, null given"

Steps to reproduce

Install and enable modules listed above. Create a workflow that sends notification to author and additional role when a node's state is changed. (sorry, lots of setup!) Trigger notification by changing the status of a node to trigger the workflow.

Proposed resolution

Modify RerouteEmailHandlerPluginBase.php to handle the case of a blank 'To' field similar to the Cc and Bcc fields

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork reroute_email-3515884

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

srees created an issue. See original summary.

srees opened merge request !95

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Active » Needs work
srees’s picture

srees commented
Status: Needs work » Needs review

jumoke made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice work, RTBC!

@bohart: FYI there are quite a lot RTBC'd issues now. Even major ones. Maybe you could have a look?

  • bohart committed ca1a46ba on 2.3.x authored by srees 
    Issue #3515884: Handled blank 'To' field when setting headers.
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Reviewed & tested by the community » Fixed

Hi @all,
Thanks to everyone for the input.

This one is merged into the 2.3.x branch and will be a part of the next release (2.3.0-rc3).
Hopefully, I will review a few other major RTBC'ed issues during the following days.
Then, after fixing all the pipelines to be green again, we will create a new module release.

This issue is marked as fixed now.
Thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.